feat(efb): troubleshooting page #9747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benjozork
previously requested changes
Jan 14, 2025
fbw-common/src/systems/instruments/src/EFB/TroubleshootingContext.tsx
Outdated
Show resolved
Hide resolved
Benjozork
reviewed
Jan 20, 2025
fbw-common/src/systems/instruments/src/EFB/Settings/Pages/AboutPage.tsx
Outdated
Show resolved
Hide resolved
flogross89
requested changes
Jan 20, 2025
There was a problem hiding this comment.
- There are a few try...catch in GuidanceController.ts and VnavDriver.ts; Do you think it makes sense to also include them? Most of the guidance errors also remain hidden. Although there's a danger of cluttering the log
- We could also consider saving these logs to a file, but you can also do this in another PR, your call.
flogross89
approved these changes
Jan 20, 2025
tracernz
force-pushed
the
mrc-troubleshooting
branch
from
1d5662d to
e63c8d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #[issue_no]
Summary of Changes
Adds a troubleshooting page under the about page in the EFB for advanced user support. The idea here is to log things that have user visible errors that don't provide enough info to determine the cause, e.g. "INTERNAL ERROR" in the FMS. It is not intended to be a general-purpose error log as it would lose it's usefulness when filled with lots of random messages like the debugger.
Hopefully we can figure out the recent spike in these INTERNAL ERRORs.
Needs #9559 merged first (for isMsfs2024 function).
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub):
Testing instructions
Go to the about page on the EFB, and then click Troubleshooting.. check that the info displayed is accurate and the layout reasonable. If you know of a repro to cause an INTERNAL ERROR on the A32NX, you could also try it to see the message in the troubleshooting log.
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.